[
https://issues.apache.org/jira/browse/MAPREDUCE-5190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643685#comment-13643685
]
Hadoop QA commented on MAPREDUCE-5190:
--------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12580837/MAPREDUCE-5190.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3552//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3552//console
This message is automatically generated.
> Unnecessary condition test in RandomSampler
> -------------------------------------------
>
> Key: MAPREDUCE-5190
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5190
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv1
> Affects Versions: 1.0.4
> Reporter: Jingguo Yao
> Assignee: Jingguo Yao
> Priority: Minor
> Attachments: MAPREDUCE-5190.patch
>
> Original Estimate: 20m
> Remaining Estimate: 20m
>
> In getSampe method, there is a condition test after "int ind =
> r.nextInt(numSamples);". The test is "(ind != numSamples)".
> This test is unneeded since nextInt(numSamples) will not return numSamples.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
