[
https://issues.apache.org/jira/browse/MAPREDUCE-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652153#comment-13652153
]
Zhijie Shen commented on MAPREDUCE-5157:
----------------------------------------
{quote}
Did you try to implement the added-back Sampler's class's getSample using the
super class implementation?
{quote}
No, because the super class uses InputSplit from mapreduece.lib, which is an
abstract class, while the implementation here needs to use InputSplit from
mapred.lib, which is an interface. InputSplit from mapred.lib doesn't extend
InputSplit from mapreduece.lib, thus, they are not compatible. Moreover, it is
much more risky to modify the interface classes.
{quote}
So all the added back code is just copy-pasted from branch-1? It did looks like
so, I cross-verfied, except the class definitions which implement from
mapreduce.* counterparts. Just confirming. Right?
{quote}
Yes, copied the copy from Branch-1
{quote}
Jumping around is in general preferable than the first N splits. Can you file a
ticket?
{quote}
I'll file a follow up ticket.
> Sort in hadoop-1 examples is not binary compatible with hadoop-2 mapred.lib
> ---------------------------------------------------------------------------
>
> Key: MAPREDUCE-5157
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5157
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Reporter: Zhijie Shen
> Assignee: Zhijie Shen
> Attachments: MAPREDUCE-5157.1.patch, MAPREDUCE-5157.1.patch
>
>
> In SORT example, org.apache.hadoop.mapred.lib.InputSampler.Sampler is used in
> hadoop-1. However, after upgrading to hadoop-2,
> org.apache.hadoop.mapred.lib.InputSampler is modified to extend
> org.apache.hadoop.mapreduce.lib.partition.InputSampler, and the inner class,
> Sampler, has been moved to the superclass. Therefore, hadoop-1 SORT can not
> find Sampler when it runs with hadoop-2 framework.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira