[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vinod Kumar Vavilapalli updated MAPREDUCE-5222:
-----------------------------------------------

    Status: Open  (was: Patch Available)

Cancelling for the comments to be addressed.

Some more comments:
 - Throwing UnSupportedOperationException breaks Apps like others noted. I 
think you should simply copy the code that is there in 1.x
 - It mostly doesn't matter without JT, but modify getStagingAreaDir to use 
clientUgi to make the call, to be consistent with other code in JobClient.
 - Clearly, no need to deprecate either of these. We stopped deprecating 
mapred.* stuff.

Also, is this everything in JobClient? I'd hate to fix these things bit by bit. 
Please see if anything else is left in JobClient to be fixed. Tx.
                
> Add missing methods to JobClient 
> ---------------------------------
>
>                 Key: MAPREDUCE-5222
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5222
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>    Affects Versions: 2.0.4-alpha
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>             Fix For: 2.0.5-beta
>
>         Attachments: mr-5222.patch, mr-5222.patch, mr-5222-rte.patch
>
>
> JobClient is missing the following two public methods we need to add for 
> binary compatibility:
> # static isJobDirValid(Path, FileSystem)
> # Path getStagingAreaDir()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to