[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13661838#comment-13661838
 ] 

Sergey Tryuber commented on MAPREDUCE-3859:
-------------------------------------------

Arun, I've attached patch for "branch-1" with testcase and fix (thanks for 
pointing me to the right branch). 

"happy to help with YARN/trunk if you want." - yes, please. You know, I had 
troubles with understanding of test cases of YARN version of CS. I'm not sure 
about correctness of testing architecture, where there is one huge capacity 
scheduler configuration with lots of queues. This scheduler configuration is 
created at the beginning of each test by "Before" method and each test uses 
that configuration. I think this is not a good choice, because it doesn't allow 
to test edge cases and hard for understanding (there are no comments at all)). 
So please, could you help me and take care about fix for YARN.

P.S. Hardcored mocks are great, but, personally, I'd prefer "old school" with 
inversion of control ("strategy" pattern) and agile architecture.
                
> CapacityScheduler incorrectly utilizes extra-resources of queue for 
> high-memory jobs
> ------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3859
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3859
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: capacity-sched
>    Affects Versions: 1.0.0
>         Environment: CDH3u1
>            Reporter: Sergey Tryuber
>            Assignee: Sergey Tryuber
>         Attachments: MAPREDUCE-3859_MR1_fix_and_test.patch.txt, 
> test-to-fail.patch.txt
>
>
> Imagine, we have a queue A with capacity 10 slots and 20 as extra-capacity, 
> jobs which use 3 map slots will never consume more than 9 slots, regardless 
> how many free slots on a cluster.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to