[
https://issues.apache.org/jira/browse/MAPREDUCE-5183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13664925#comment-13664925
]
Sandy Ryza commented on MAPREDUCE-5183:
---------------------------------------
Thanks for working on this, Niranjan. The patch is looking good. A couple
stylistic comments:
* The line you changed should be broken up so that it fits within 80 characters
per line
* There should be a space between the comma and the 0.
* There should be 0 or 1 blank lines at the end of the test function, and no
blank lines at the end of the for loop in the test.
* Tests that run a job on a minicluster generally take over a minute. Would it
be possible to either write the test without the whole job/minicluster or put
the check inside a relevant test that already exists? Also, and others might
disagree, I don't think a test is necessarily required for something cosmetic
like this.
Also, I removed the fix version, as normally the person who commits the patch
sets it at commit time.
> In, TaskTracker#reportProgress logging of 0.0-1.0 progress is followed by
> percent sign
> --------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-5183
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5183
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv1, tasktracker
> Affects Versions: 1.1.2
> Reporter: Sandy Ryza
> Priority: Minor
> Labels: newbie
> Attachments: MAPREDUCE-5183.patch
>
>
> This makes looking at progress in the logs unnecessarily confusing. It would
> probably look prettiest to keep the percentage sign and have the numbers
> between 0 and 100.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
