[
https://issues.apache.org/jira/browse/MAPREDUCE-5228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vinod Kumar Vavilapalli updated MAPREDUCE-5228:
-----------------------------------------------
Status: Open (was: Patch Available)
Looked at the patch. few comments:
- None of depricatedCounterMap, initDepricatedMap and getNewGroupKey need to
be public.
- initDepricatedMap() is static. So no need to call it in a constructor. Just
call it in a static block.
- initDepricatedMap(): Instead of hard-coding string names, can't you use
Class.getName() ?
- The logic can be per-counter instead of per-group. That way, even
MAP_INPUT_BYTES can be handled the same way. May be later.
- Instead of cloning testOldCounterA(), why don't you call
validateOldFileCounters() wherever validateFileCounters is called?
> Enum Counter is removed from FileInputFormat and FileOutputFormat of both
> mapred and mapreduce
> ----------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-5228
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5228
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Reporter: Zhijie Shen
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-5228-trunk-1.patch,
> MAPREDUCE-5228-trunk-2.patch
>
>
> The enum was used by findCounter(Enum key) to find a specific counter object.
> Now it seems to be replaced by FileInputFormatCounter and
> FileOutputFormatCounter. Now the enum seems to be only used internally, but
> not sure whether it will be used externally when users extend FileXXXXFormat.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
