[
https://issues.apache.org/jira/browse/MAPREDUCE-5203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vinod Kumar Vavilapalli updated MAPREDUCE-5203:
-----------------------------------------------
Status: Open (was: Patch Available)
Quick comments on the patch:
- The patch needs to be updated after YARN-117. You should only override
serviceInit()/serviceStart()/serviceStop() in the new service.
- Default launcher should be the new launcher.
- Should ContainerLauncherViaNMClient.serviceStop() inspect
super.cleanupRunningContainers to clear taskAttemptIds?
- Rename the new config to be yarn.app.mapreduce.am.container-launcher.class
- Similarly MRJobConfig.MR_AM_CONTAINER_LAUNCHER to
MRJobConfig.MR_AM_CONTAINER_LAUNCHER_CLASS
- MRAppMaster: Simply catch Exception and wrap it instead of catching each one.
- Test:
-- The records in setup() can just be creating instead of mocking and then
at the end of it returning every field.
-- In case of startContainer error, validate that specific TaskAttempt
event is handled instead of just the number? Lines +134 and +171
> Make AM of M/R Use NMClient
> ---------------------------
>
> Key: MAPREDUCE-5203
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5203
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Zhijie Shen
> Assignee: Zhijie Shen
> Attachments: MAPREDUCE-5203.1.patch, MAPREDUCE-5203.2.patch
>
>
> YARN-422 adds NMClient. AM of mapreduce should use it instead of using the
> raw ContainerManager proxy directly. ContainerLauncherImpl needs to be
> changed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
