[
https://issues.apache.org/jira/browse/MAPREDUCE-5356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13709256#comment-13709256
]
Jason Lowe commented on MAPREDUCE-5356:
---------------------------------------
Some comments after a brief perusal of the patch:
* HSAdminProtocol moved between packages, should this really be part of
MAPREDUCE-5265?
* I don't think we want a separate rpc/service definition for each of these
HS-specific refresh directives, rather a series of them wrapped in a single or
just a few would probably be more manageable.
GetUserMappings/RefreshUserMappings are separated for reuse, but it seems
unlikely these other refreshes will be reused by others so not sure the
fine-grained separation is desirable. I'd suggest something like an
HSAdminRefreshProtocol that contains all the HS-specific refreshes to cut down
on the number of PB-wrapper classes needed.
* For completeness we should check if the service is stopped before allowing a
new timer to be scheduled.
> Refresh Log aggregation 'retention period' and 'check interval'
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-5356
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5356
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: jobhistoryserver
> Affects Versions: 2.1.0-beta
> Reporter: Ashwin Shankar
> Assignee: Ashwin Shankar
> Labels: features
> Attachments: MAPREDUCE-5266-2.txt, MAPREDUCE-5266-3.txt,
> MAPREDUCE-5266-4.txt
>
>
> We want to be able to refresh log aggregation retention time
> and 'check interval' time on the fly by changing configs so that we dont have
> to bounce history server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
