[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13710392#comment-13710392
 ] 

Shinichi Yamashita commented on MAPREDUCE-5392:
-----------------------------------------------

Thank you for comment.

{quote}
This config.get() always returns "localhost", because the instance of 
Configuration class is created with no user-defined configurations. In fully 
distributed mode, it may not works well.
{quote}

Configuration() can reads the configuration files in the classpath. So, if 
"mapreduce.jobhistory.webapp.address" defines it with the configuration file 
(e.g. yarn-site.xml) in the classpath, it does not have any problem.

About HostUtil.java I agree of your thought. And I fixed it to handle 
HostUtil.java with or without "tracker_".
I attach a new patch file.
                
> Fix "mapred job -history all" command
> -------------------------------------
>
>                 Key: MAPREDUCE-5392
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5392
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 3.0.0
>            Reporter: Shinichi Yamashita
>            Assignee: Shinichi Yamashita
>            Priority: Minor
>         Attachments: MAPREDUCE-5392.patch, MAPREDUCE-5392.patch
>
>
> When I use an "all" option by "mapred job -history" comamnd, the following 
> exceptions are displayed and do not work.
> {code}
> Exception in thread "main" java.lang.StringIndexOutOfBoundsException: String 
> index out of range: -3
>         at java.lang.String.substring(String.java:1875)
>         at 
> org.apache.hadoop.mapreduce.util.HostUtil.convertTrackerNameToHostName(HostUtil.java:49)
>         at 
> org.apache.hadoop.mapreduce.jobhistory.HistoryViewer.getTaskLogsUrl(HistoryViewer.java:459)
>         at 
> org.apache.hadoop.mapreduce.jobhistory.HistoryViewer.printAllTaskAttempts(HistoryViewer.java:235)
>         at 
> org.apache.hadoop.mapreduce.jobhistory.HistoryViewer.print(HistoryViewer.java:117)
>         at org.apache.hadoop.mapreduce.tools.CLI.viewHistory(CLI.java:472)
>         at org.apache.hadoop.mapreduce.tools.CLI.run(CLI.java:313)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
>         at org.apache.hadoop.mapred.JobClient.main(JobClient.java:1233)
> {code}
> This is because a node name recorded in History file is not given "tracker_". 
> Therefore it makes modifications to be able to read History file even if a 
> node name is not given by "tracker_".
> In addition, it fixes the URL of displayed task log.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to