[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13716470#comment-13716470
 ] 

Hitesh Shah commented on MAPREDUCE-5408:
----------------------------------------

Mostly looks good. A couple of minor comments:

  - DEFAULT_LOG_LEVEL could be renamed to DEFAULT_TASK_LOG_LEVEL and the type 
changed to a string. Having the type as Level is not buying much as it always 
ends up being converted to a string when used. If the intention is to retain 
the backport as is, this comment can be ignored for now. 

  - Level.toLevel() has an api which takes in a default value. In the event 
that the user has a typo, the current usage falls back to using DEBUG where as 
the default-based api can be made to fall back to INFO.


 
                
> CLONE - The logging level of the tasks should be configurable by the job
> ------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5408
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5408
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Owen O'Malley
>            Assignee: Arun C Murthy
>             Fix For: 1.3.0
>
>         Attachments: MAPREDUCE-336_branch1.patch
>
>
> It would be nice to be able to configure the logging level of the Task JVM's 
> separately from the server JVM's. Reducing logging substantially increases 
> performance and reduces the consumption of local disk on the task trackers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to