[
https://issues.apache.org/jira/browse/MAPREDUCE-5403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718797#comment-13718797
]
Bikas Saha commented on MAPREDUCE-5403:
---------------------------------------
why are we using a literal string instead of a programming friendly constant?
Literal string is error-prone and hard to maintain.
Why have we changed YARN_APPLICATION_CLASSPATH to NM_APPLICATION_CLASSPATH? The
config will be identical across NM's in the common case. Regardless, is this a
configuration for the yarn application or the NM?
Mixing NM_APPLICATION_CLASSPATH with YARN_APPLICATION_CLASSPATH_DEFAULT???
{code}
+ classPathEnv.append(File.pathSeparatorChar)
+ .append("$YARN_APPLICATION_CLASSPATH");
{code}
{code}
- Map<String, String> environment = launchContext.getEnvironment();
+ LinkedHashMap<String, String> environment = new LinkedHashMap<String,
String>();
+ for (String c : conf.getStrings(
+ YarnConfiguration.NM_APPLICATION_CLASSPATH,
+ YarnConfiguration.DEFAULT_YARN_APPLICATION_CLASSPATH)) {
+ Apps.addToEnvironment(environment, "YARN_APPLICATION_CLASSPATH", c
+ .trim());
+ }
+ environment.putAll(launchContext.getEnvironment());
{code}
> yarn.application.classpath requires client to know service internals
> --------------------------------------------------------------------
>
> Key: MAPREDUCE-5403
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5403
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: client
> Affects Versions: 2.0.5-alpha
> Reporter: Sandy Ryza
> Assignee: Sandy Ryza
> Attachments: MAPREDUCE-5403-1.patch, MAPREDUCE-5403.patch
>
>
> yarn.application.classpath is a confusing property because it is used by
> MapReduce and not YARN, and MapReduce already has
> mapreduce.application.classpath, which provides the same functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
