[ https://issues.apache.org/jira/browse/MAPREDUCE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinod Kumar Vavilapalli updated MAPREDUCE-5476: ----------------------------------------------- Status: Open (was: Patch Available) The approach sounds fine to me. This looks like a clear follow up from MAPREDUCE-4819 that we never pursued. OTOH, though I didn't always feel comforable with the FINISHING state, things like these prove its practical wins :) Re the patch: - The java comments needs to be slightly improved to reflect what we are really doing - Test: -- Rename cleanupStagingDir to stagingDirCleanedUp. -- Not related to your patch but can you also modify the test a little to make sure the JobHistoryEventHandler is the first thing to shut-down? > Job can fail when RM restarts after staging dir is cleaned but before MR > successfully unregister with RM > -------------------------------------------------------------------------------------------------------- > > Key: MAPREDUCE-5476 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5476 > Project: Hadoop Map/Reduce > Issue Type: Bug > Reporter: Jian He > Assignee: Jian He > Priority: Blocker > Attachments: MAPREDUCE-5476.patch, YARN-917.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira