[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758570#comment-13758570
 ] 

Hadoop QA commented on MAPREDUCE-5497:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12601513/MAPREDUCE-5497.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app:

                  org.apache.hadoop.mapreduce.v2.app.TestKill
                  org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator
                  org.apache.hadoop.mapreduce.v2.app.TestRecovery
                  
org.apache.hadoop.mapreduce.v2.app.launcher.TestContainerLauncher
                  org.apache.hadoop.mapreduce.v2.app.TestAMInfos
                  org.apache.hadoop.mapreduce.v2.app.TestFail
                  org.apache.hadoop.mapreduce.v2.app.job.impl.TestTaskAttempt
                  org.apache.hadoop.mapreduce.v2.app.TestFetchFailure
                  
org.apache.hadoop.mapreduce.v2.app.job.impl.TestMapReduceChildJVM
                  org.apache.hadoop.mapreduce.v2.app.TestMRApp

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3981//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3981//console

This message is automatically generated.
                
> '5s sleep'  in MRAppMaster.shutDownJob is only needed before stopping 
> ClientService
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5497
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5497
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Jian He
>            Assignee: Jian He
>         Attachments: MAPREDUCE-5497.patch
>
>
> Since the '5s sleep' is for the purpose to let clients know the final states, 
> put it after other services are stopped and only before stopping 
> ClientService is enough. This can reduce some race conditions like 
> MAPREDUCE-5471

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to