[
https://issues.apache.org/jira/browse/MAPREDUCE-5497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vinod Kumar Vavilapalli updated MAPREDUCE-5497:
-----------------------------------------------
Target Version/s: 2.1.1-beta
Status: Open (was: Patch Available)
Quick comments on the patch:
- Change ClientService to extend Service. That way you don't need the
type-casting in MRAppMaster.
- The start of client-service in MRAppMaster.serviceStart() should not be
under the condition for errorHappenedShutDown.
- Fix formatting in the changes done for MRApp.java
- Can you move the checks for JobHistoryEventHandler and ClientService into a
stand-alone test say TestMRAppComponentDependencies or something similar? They
don't belong to the staging-cleanup test.
> '5s sleep' in MRAppMaster.shutDownJob is only needed before stopping
> ClientService
> -----------------------------------------------------------------------------------
>
> Key: MAPREDUCE-5497
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5497
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Jian He
> Assignee: Jian He
> Attachments: MAPREDUCE-5497.1.patch, MAPREDUCE-5497.patch
>
>
> Since the '5s sleep' is for the purpose to let clients know the final states,
> put it after other services are stopped and only before stopping
> ClientService is enough. This can reduce some race conditions like
> MAPREDUCE-5471
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
