[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13773155#comment-13773155
 ] 

Jason Lowe commented on MAPREDUCE-5503:
---------------------------------------

bq. I think TestMRJobClient expect to test operations for running MapReduce 
jobs.

It doesn't appear that way, as the first thing it does is run a job and wait 
for it to complete then all the subsequent tests are using that (now completed) 
jobID.  A comment in testJobList even indicates it expects completed jobs to 
not be in the list.  I suspect the only reason this test passed previously was 
because the 5s sleep between the job stating to clients that it had completed 
but before it unregistered with the RM, so for 5 seconds a job could be in a 
completed state to the client but the RM would report it as running.  
MAPREDUCE-5497 changed it so it now unregisters immediately after the job 
succeeds.

Arguably testJobList should have two jobs, one completed and one running, to 
really test if "-list" only shows active jobs and "-list all" shows all jobs.
                
> TestMRJobClient.testJobClient is failing
> ----------------------------------------
>
>                 Key: MAPREDUCE-5503
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5503
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 3.0.0, 2.1.0-beta
>            Reporter: Jason Lowe
>            Priority: Blocker
>         Attachments: MAPREDUCE-5503.patch
>
>
> TestMRJobClient.testJobClient is failing on trunk and causing precommit 
> builds to complain:
> {noformat}
> testJobClient(org.apache.hadoop.mapreduce.TestMRJobClient)  Time elapsed: 
> 26.361 sec  <<< FAILURE!
> junit.framework.AssertionFailedError: expected:<1> but was:<0>
>       at junit.framework.Assert.fail(Assert.java:50)
>       at junit.framework.Assert.failNotEquals(Assert.java:287)
>       at junit.framework.Assert.assertEquals(Assert.java:67)
>       at junit.framework.Assert.assertEquals(Assert.java:199)
>       at junit.framework.Assert.assertEquals(Assert.java:205)
>       at 
> org.apache.hadoop.mapreduce.TestMRJobClient.testJobList(TestMRJobClient.java:474)
>       at 
> org.apache.hadoop.mapreduce.TestMRJobClient.testJobClient(TestMRJobClient.java:112)
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to