[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Lowe updated MAPREDUCE-5332:
----------------------------------

    Attachment: MAPREDUCE-5332-7.patch

Thanks for the thorough review, Daryn!  Updated the patch to address all but 
one of the concerns.  High-level changes include:

* Added an updateToken method to the state store interface, and filesystem 
store uses rename to try to make this atomic.
* Token buckets are created up front

bq. The DTSM has the stateStore so its recovery method could load the state - 
instead of the caller loading the state from the stateStore and passing it in. 
The code may become a bit easier to follow, but just a suggestion.

I kept this as-is.  It makes more sense if the history server were to persist 
more items in the future than just these tokens, as you'd want to load the 
state once then dole out the bits of state to the various entities that need to 
recover using that state.  Either that or the state stores should just be 
separate and per-service, then I agree that the recovery would be handled by 
each service.

                
> Support token-preserving restart of history server
> --------------------------------------------------
>
>                 Key: MAPREDUCE-5332
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5332
>             Project: Hadoop Map/Reduce
>          Issue Type: New Feature
>          Components: jobhistoryserver
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>         Attachments: MAPREDUCE-5332-2.patch, MAPREDUCE-5332-3.patch, 
> MAPREDUCE-5332-4.patch, MAPREDUCE-5332-5.patch, MAPREDUCE-5332-5.patch, 
> MAPREDUCE-5332-6.patch, MAPREDUCE-5332-7.patch, MAPREDUCE-5332.patch
>
>
> To better support rolling upgrades through a cluster, the history server 
> needs the ability to restart without losing track of delegation tokens.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to