[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776801#comment-13776801
 ] 

Bikas Saha commented on MAPREDUCE-5505:
---------------------------------------

Instead of calling rememberLastState in every transition (which is also not 
future proof) can we call it in JobImpl.handle(). This is where the transition 
method gets called.

Similarly, createRunningStubbedJob() can implicitly create a mockContext that 
returns true. Only in the relevant tests, we can pass in/override the 
mockContext to return false. This will reduce the code change.

Rest looks good to me.
                
> Clients should be notified job finished only after job successfully 
> unregistered 
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5505
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5505
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Jian He
>            Assignee: Zhijie Shen
>         Attachments: MAPREDUCE-5505.1.patch, MAPREDUCE-5505.1.patch, 
> MAPREDUCE-5505.3.patch, MAPREDUCE-5505.4.patch, MAPREDUCE-5505.5.patch
>
>
> This is to make sure user is notified job finished after job is really done. 
> This does increase client latency but can reduce some races during unregister 
> like YARN-540

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to