[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782471#comment-13782471
 ] 

Omkar Vinit Joshi commented on MAPREDUCE-5536:
----------------------------------------------

Thanks vinod..

bq. WebAppUtil.getDefaultJHSWebappPort() and 
getDefaultJHSWebappURLWithoutScheme() can be private
fixed..

bq. getHistoryUrl() -> getApplicationHistoryURLWithoutScheme().
fixed.

bq. getJHSWebappURLWithScheme() : No need to have a isSSLEnabledInJHS check.
fixed.

bq. getJHSSchemePrefix() -> getJHSWebAppSchemePrefix()()
fixed.

bq. Add a getApplicationHistoryURLWithSchem() and use in MR AM's RMCommunicator?
fixed.

bq. MR's WebAppUtil -> Mark as Private. - WebAppUtil -> MRWebAppUtil.
fixed..

bq. JHAdminConfig.getResolvedMRHistoryWebAppURLWithoutScheme() still takes in a 
flag - it doesn't need to. And may be move it to MiniMRYarnCluster if that is 
the only caller.
moved it to MiniMRYarnCluster

bq. I think instead of WebAppUtil.setSSLEnabledIn*() methods, we should have 
WebAppUtil.initialize(Configuration conf). That way, every component doesn't 
need to remember what config to read.
fixed.


> mapreduce.jobhistory.webapp.https.address property is not respected
> -------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5536
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5536
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 2.1.1-beta
>            Reporter: Yesha Vora
>            Assignee: Omkar Vinit Joshi
>            Priority: Blocker
>         Attachments: MAPREDUCE-5536.20131027.1.patch, 
> MAPREDUCE-5536.20131030.1.patch, MAPREDUCE-5536.20131030.1.patch, 
> YARN-1240.20131025.1.patch
>
>
> The jobhistory server starts on port defined by 
> mapreduce.jobhistory.webapp.address property instead 
> mapreduce.jobhistory.webapp.https.address when hadoop.ssl.enabled=true.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to