[
https://issues.apache.org/jira/browse/MAPREDUCE-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13784010#comment-13784010
]
Hadoop QA commented on MAPREDUCE-5549:
--------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12606282/MAPREDUCE-5549-001.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-tools/hadoop-distcp.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4079//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4079//console
This message is automatically generated.
> distcp app should fail if m/r job fails
> ---------------------------------------
>
> Key: MAPREDUCE-5549
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5549
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: distcp, mrv2
> Affects Versions: 3.0.0
> Reporter: David Rosenstrauch
> Attachments: MAPREDUCE-5549-001.patch
>
>
> I run distcpv2 in a scripted manner. The script checks if the distcp step
> fails and, if so, aborts the rest of the script. However, I ran into an
> issue today where the distcp job failed, but my calling script went on its
> merry way.
> Digging into the code a bit more (at
> https://svn.apache.org/repos/asf/hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java),
> I think I see the issue: the distcp app is not returning an error exit code
> to the shell when the distcp job fails. This is a big problem, IMO, as it
> prevents distcp from being successfully used in a scripted environment. IMO,
> the code should change like so:
> Before:
> {code:title=org.apache.hadoop.tools.DistCp.java}
> //...
> public int run(String[] argv) {
> //...
> try {
> execute();
> } catch (InvalidInputException e) {
> LOG.error("Invalid input: ", e);
> return DistCpConstants.INVALID_ARGUMENT;
> } catch (DuplicateFileException e) {
> LOG.error("Duplicate files in input path: ", e);
> return DistCpConstants.DUPLICATE_INPUT;
> } catch (Exception e) {
> LOG.error("Exception encountered ", e);
> return DistCpConstants.UNKNOWN_ERROR;
> }
> return DistCpConstants.SUCCESS;
> }
> //...
> {code}
> After:
> {code:title=org.apache.hadoop.tools.DistCp.java}
> //...
> public int run(String[] argv) {
> //...
> Job job = null;
> try {
> job = execute();
> } catch (InvalidInputException e) {
> LOG.error("Invalid input: ", e);
> return DistCpConstants.INVALID_ARGUMENT;
> } catch (DuplicateFileException e) {
> LOG.error("Duplicate files in input path: ", e);
> return DistCpConstants.DUPLICATE_INPUT;
> } catch (Exception e) {
> LOG.error("Exception encountered ", e);
> return DistCpConstants.UNKNOWN_ERROR;
> }
> if (job.isSuccessful()) {
> return DistCpConstants.SUCCESS;
> }
> else {
> return DistCpConstants.UNKNOWN_ERROR;
> }
> }
> //...
> {code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
