[
https://issues.apache.org/jira/browse/MAPREDUCE-5530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13784127#comment-13784127
]
Hudson commented on MAPREDUCE-5530:
-----------------------------------
SUCCESS: Integrated in Hadoop-trunk-Commit #4517 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/4517/])
MAPREDUCE-5530. Fix compat with hadoop-1 in mapred.lib.CombinFileInputFormat by
re-introducing isSplittable(FileSystem, Path) api and ensuring semantic
compatibility. Contributed by Robert Kanter. (acmurthy:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1528533)
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
*
/hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/lib/CombineFileInputFormat.java
> Binary and source incompatibility in mapred.lib.CombineFileInputFormat
> between branch-1 and branch-2
> ----------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-5530
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5530
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: mrv1, mrv2
> Affects Versions: 2.1.1-beta
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Priority: Blocker
> Fix For: 2.1.2-beta
>
> Attachments: MAPREDUCE-5530.patch, MAPREDUCE-5530.patch,
> MAPREDUCE-5530.patch, MAPREDUCE-5530.patch
>
>
> {{mapred.lib.CombineFileInputFormat}} in branch-1 has this method:
> {code:java}
> protected boolean isSplitable(FileSystem fs, Path file)
> {code}
> In branch-2, {{mapred.lib.CombineFileInputFormat}} is now a subclass of
> {{mapreduce.lib.input.CombineFileInputFormat}}, from which it inherits the
> similar method:
> {code:java}
> protected boolean isSplitable(JobContext context, Path file)
> {code}
> This means that any code that subclasses
> {{mapred.lib.CombineFileInputFormat}} and does not provide its own
> implementation of {{protected boolean isSplitable(FileSystem fs, Path file)}}
> will not be binary or source compatible if it tries to call {{isSplitable}}
> with a {{FileSystem}} argument anywhere (that is, if compiled against
> branch-1, it will throw a {{NoSuchMethodError}} if run against branch-2;
> also, it won't even compile against branch-2).
--
This message was sent by Atlassian JIRA
(v6.1#6144)
