[ https://issues.apache.org/jira/browse/MAPREDUCE-5562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787482#comment-13787482 ]
Vinod Kumar Vavilapalli commented on MAPREDUCE-5562: ---------------------------------------------------- Comments on the test: - In TestMRApp, testJobRebootNotLastRetryOnUnregistrationSuccess naming is wrong. It should be testJobRebootNotLastRetryOnUnregistrationFailure. - TestStagingCleanup.shouldDelete -> shouldHaveDeleted. - Also change TestJobEndNotifier to be similar to TestStagingCleanup -- Single AM attempt job should send it irrespective of AM failure -- Two attempts job should not send it for the first AM failure. > MR AM should exit when unregister() throws exception > ---------------------------------------------------- > > Key: MAPREDUCE-5562 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5562 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Reporter: Zhijie Shen > Assignee: Zhijie Shen > Attachments: MAPREDUCE-5562.1.patch, MAPREDUCE-5562.2.patch, > MAPREDUCE-5562.3.patch, MAPREDUCE-5562.5.patch, MAPREDUCE-5562.6.patch, > MAPREDUCE-5562.7.patch > > -- This message was sent by Atlassian JIRA (v6.1#6144)