[
https://issues.apache.org/jira/browse/MAPREDUCE-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793046#comment-13793046
]
Sandy Ryza commented on MAPREDUCE-5517:
---------------------------------------
The patch looks good to me other than a few stylistic nits:
{code}
+ || (numReduceTasks == 0 && conf.getLong(MRJobConfig.MAP_MEMORY_MB,
0) <= sysMemSizeForUberSlot));
{code}
This line looks like it's over 80 characters.
{code}
-
+
{code}
False whitespace change
{code}
+
+ // enable uber mode of 0 reducer no matter how much memory we assign to
reducer
+ conf = new Configuration();
+ conf.setBoolean(MRJobConfig.JOB_UBERTASK_ENABLE, true);
+ conf.setInt(MRJobConfig.NUM_REDUCES, 0); //actual num of
reducer set to 0
+ conf.setInt(MRJobConfig.REDUCE_MEMORY_MB, 2048);
//mapreduce.reduce.memory.mb set to 2048 MB which is larger than
yarn.app.mapreduce.am.resource.mb(1536 MB by default)
+ isUber = testUberDecision(conf);
+ Assert.assertTrue(isUber);
{code}
Spaces should be used instead of tabs
> enabling uber mode with 0 reducer still requires mapreduce.reduce.memory.mb
> to be less than yarn.app.mapreduce.am.resource.mb
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-5517
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5517
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 2.0.5-alpha
> Reporter: Siqi Li
> Priority: Minor
> Attachments: MAPREDUCE_5517_v3.patch.txt
>
>
> Since there is no reducer, the memory allocated to reducer is irrelevant to
> enable uber mode of a job
--
This message was sent by Atlassian JIRA
(v6.1#6144)
