[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798546#comment-13798546
 ] 

Ravi Prakash commented on MAPREDUCE-5587:
-----------------------------------------

Thanks Jon. Minor nits: 
- in testCompress(), you didn't have to remove separator. I'd rather check 
\u0001 than \t.
- {code} output += out + "\n"; {code}
- Do you think we should clean up the output files in an @After ? Or do you 
think its more useful to have them around after the test for debugging? I could 
go either way.

Otherwise patch looks good.

> TestTextOutputFormat fails on JDK7
> ----------------------------------
>
>                 Key: MAPREDUCE-5587
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5587
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 2.3.0, 0.23.10
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>         Attachments: MAPREDUCE-5587.patch
>
>
> the test method run order on JDK7 is not fixed causing test method 
> inter-dependencies to show themselves.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to