[jira] [Commented] (MAPREDUCE-5610) TestSleepJob fails in jdk7

[Jason Lowe (JIRA)]

    [ 
https://issues.apache.org/jira/browse/MAPREDUCE-5610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820667#comment-13820667
 ] 

Jason Lowe commented on MAPREDUCE-5610:
---------------------------------------

Thanks, Jon.  One nit is that the conditions are now more complex than 
necessary, as this code:

{code}
      if (numLocations < 0) numLocations=0;
      if ((numLocations >= 0) && (hosts == null)) {
{code}

should just be simplified to:

{code}
      if (numLocations < 0) numLocations=0;
      if (hosts == null) {
{code}

It's more clear that we want to initialize hosts whenever it's null and not 
dependent upon some other condition as well.

> TestSleepJob fails in jdk7
> --------------------------
>
>                 Key: MAPREDUCE-5610
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5610
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>         Attachments: MAPREDUCE-5610.patch, MAPREDUCE-5610.patch, 
> MAPREDUCE-5610.patch
>
>
> In jdk7 tests methods in a class do not run in file order, but rather in 
> random order. TestSleepJob hosts are not initialized and a 
> NullPointerException is thrown unless testRandomLocation was run first.
> This can be easily seen by running tests individually.
> org.apache.hadoop.mapred.gridmix.TestSleepJob#testStressSubmit
> org.apache.hadoop.mapred.gridmix.TestSleepJob#testReplaySubmit
> org.apache.hadoop.mapred.gridmix.TestSleepJob#testSerialSubmit
> org.apache.hadoop.mapred.gridmix.TestSleepJob#testMapTasksOnlySleepJobs
> org.apache.hadoop.mapred.gridmix.TestSleepJob#testRandomLocation



--
This message was sent by Atlassian JIRA
(v6.1#6144)