[ https://issues.apache.org/jira/browse/MAPREDUCE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820906#comment-13820906 ]
Junping Du commented on MAPREDUCE-5593: --------------------------------------- The test failure seems to be unrelated with the patch (also failed on clean trunk branch in my local env) and may caused by MAPREDUCE-5427. Will do more investigation soon. > Cleanup code for AssignMapsWithLocality() in RMContainerAllocator > ----------------------------------------------------------------- > > Key: MAPREDUCE-5593 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5593 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: applicationmaster > Reporter: Junping Du > Assignee: Junping Du > Priority: Minor > Attachments: MAPREDUCE-5593-v3.patch, MAPREDUCE-5593-v4.patch, > YARN-1163-v1.patch, YARN-1163-v2.patch > > > In RMContainerAllocator, AssignMapsWithLocality() is a very important method > to assign map tasks on allocated containers with conforming different level > of locality (dataLocal, rackLocal, etc.). However, this method messed with > different code logic to handle different type of locality but have lots of > similar behaviours. This is hard to maintain as well as do extension with > other locality type, so we need some more clear code here. -- This message was sent by Atlassian JIRA (v6.1#6144)