[
https://issues.apache.org/jira/browse/MAPREDUCE-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826292#comment-13826292
]
Joshua Caplan commented on MAPREDUCE-3310:
------------------------------------------
Thank you for taking this on. I have some humble naming suggestions.
Could we name the getter/setter as in "setCombinerKeyGroupingComparator",
rather than "setOutputValueCombinerGroupingComparator"? The portions of the
records involved are neither "outputs" (they're intermediate records) nor
"values" (they're keys). The existing getter/setter
"setOutputValueGroupingComparator" that you extrapolated is a terrible name
that we're apparently stuck with.
Similarly, "mapreduce.job.output.combiner.group.comparator.class" as a property
name might be better rendered "mapreduce.job.combiner.group.comparator.class".
Again, we are not really dealing with outputs in the general case with
combiners.
Finally, should you add "@see" comments to the traditional output comparator
setters?
> Custom grouping comparator cannot be set for Combiners
> ------------------------------------------------------
>
> Key: MAPREDUCE-3310
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3310
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: client
> Affects Versions: 0.20.1
> Environment: All
> Reporter: Mathias Herberts
> Assignee: Alejandro Abdelnur
> Attachments: MAPREDUCE-3310-branch-1.patch,
> MAPREDUCE-3310-trunk.patch, MAPREDUCE-3310-trunk.patch,
> MAPREDUCE-3310-trunk.patch
>
>
> Combiners are often described as 'Reducers running on the Map side'.
> As Reducers, Combiners are fed <K,{V}>, where {V} is built by grouping values
> associated with the 'same' key.
> For Reducers, the comparator used for grouping values can be set
> independently of that used to sort the keys (using
> Job.setGroupingComparatorClass).
> Such a configuration is not possible for Combiners, meaning some things done
> in Reducers cannot be done in Combiners (such as secondary sort).
> It would be handy to have a Job.setCombinerGroupingComparatorClass method
> that would allow the setting of the grouping comparator used when applying a
> Combiner.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
