[
https://issues.apache.org/jira/browse/MAPREDUCE-5723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13873038#comment-13873038
]
Karthik Kambatla commented on MAPREDUCE-5723:
---------------------------------------------
Thanks [~kamrul]. The patch definitely looks better now. Should have mentioned
this earlier, but it would be nice to add a unit test. How about something that
just verifies LogManager.shutdown is called - may be using spy?
I ll have to verify why TestRMContainerAllocator is failing, but we can ignore
the failure if it is also failing on trunk without the patch.
> MR AM container log empty if exception occurs
> ---------------------------------------------
>
> Key: MAPREDUCE-5723
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5723
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: applicationmaster
> Affects Versions: 2.2.0
> Reporter: Mohammad Kamrul Islam
> Assignee: Mohammad Kamrul Islam
> Fix For: trunk, 2.2.0
>
> Attachments: MAPREDUCE-5723.1.patch, MAPREDUCE-5723.2.patch,
> MAPREDUCE-5723.3.patch
>
>
> It occurs when the property "mapreduce.task.userlog.limit.kb" is set non-zero
> in mapped-site.xml.
> AM container syslog remains empty if any exception occurs.
> Bug details:
> In MRAppMaster.java, the following code snippets show the bug.
> {code}
> } catch (Throwable t) {
> LOG.fatal("Error starting MRAppMaster", t);
> System.exit(1);
> }finally {
> LogManager.shutdown();
> }
> {code}
> In the catch block, we are exiting the JVM. So finally block (therefore
> LogManager.shutdown()) is never executed.
> Possible fix:
> Make sure LogManager.shutdown() is executed in all cases.
>
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
