[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892756#comment-13892756
 ] 

Sandy Ryza commented on MAPREDUCE-5699:
---------------------------------------

bq. In addition to pass tags when being submitted to YARN, should we make the 
running MRAppMaster/Job remember the tags as well.
Because the tags go in the job configuration, the MRAppMaster and JHS will have 
access to them.

Comments on the patch:
{code}
 <?xml version="1.0"?>
+<?xml-stylesheet type="text/xsl" href="configuration.xsl"?>
 <!--
    Licensed to the Apache Software Foundation (ASF) under one or more
    contributor license agreements.  See the NOTICE file distributed with
@@ -15,7 +16,6 @@
    See the License for the specific language governing permissions and
    limitations under the License.
 -->
-<?xml-stylesheet type="text/xsl" href="configuration.xsl"?>
{code}
False change?

{code}
+    <description> Tags for the job, the corresponding YARN application
+      inherits these tags. The ResourceManager can be queried for any of
+      these tags to fetch this application.
{code}
First sentence is a little awkward.  Second makes it a little unclear that AHS 
can be queried for them too. Maybe use "Tags for the job that will be passed to 
YARN at submission time.  Queries to YARN for applications can filter on these 
tags."

Otherwise, LGTM.

> Tagging support for MR jobs
> ---------------------------
>
>                 Key: MAPREDUCE-5699
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5699
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: applicationmaster
>    Affects Versions: 2.3.0
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: mr-5699-1.patch, mr-5699-1.patch, mr-5699-2.patch
>
>
> YARN-1399 / YARN-1461 add support for tagging YARN applications. MR should 
> expose to users, so they can set tags on an MR job. 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to