[
https://issues.apache.org/jira/browse/MAPREDUCE-5754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910961#comment-13910961
]
Jason Lowe commented on MAPREDUCE-5754:
---------------------------------------
The patch has gone stale and no longer applies cleanly. My apologies for not
getting to this sooner.
Some other comments on the patch:
- Nit: Is it appropriate to put a particular diagnostic string in the Job
interface? Wondering if this is more appropriately placed in JobImpl, as the
wording of diagnostic messages seems implementation-specific and not something
that necessarily belongs in the interface.
- Timeout for TestEvents.testEvent was commented out.
- Why are we joining diagnostics with ','? JobImpl.getReport() joins with '\n'
so there would be some inconsistency.
- Why does JobUnsuccessfulCompletionEvent.getDiagnostics() explicitly check for
"N/A" and translate it to an empty string? Can we just have the Avro spec
default to "" and remove this check or is there another use-case for this
transform?
- Did you run a test where the history server tried to parse an old history
file generated before this change? It *should* work given the Avro default,
but it would be nice to confirm since there were issues in the past with
compatibility.
> Preserve Job diagnostics in history
> -----------------------------------
>
> Key: MAPREDUCE-5754
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5754
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: jobhistoryserver, mr-am
> Affects Versions: 2.2.0
> Reporter: Gera Shegalov
> Assignee: Gera Shegalov
> Attachments: MAPREDUCE-5754.v01.patch, MAPREDUCE-5754.v02.patch
>
>
> History does not store the runtime diagnostics information. JobHistoryParser
> tries to blame a task. We propose to preserve the original runtime
> diagnostics that covers all the cases including the job being killed. This is
> particularly important in the context of user-supplied diagnostic message as
> in MAPREDUCE-5648.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
