[
https://issues.apache.org/jira/browse/MAPREDUCE-4878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13913623#comment-13913623
]
Hadoop QA commented on MAPREDUCE-4878:
--------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12554239/HADOOP-9065.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core:
org.apache.hadoop.mapred.TestOldMethodsJobID
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4378//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4378//console
This message is automatically generated.
> JobID.forName() isn't strict enough
> -----------------------------------
>
> Key: MAPREDUCE-4878
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4878
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Attachments: HADOOP-9065.patch, HADOOP-9065_branch-1.patch
>
>
> If you have a job running as job_201208221603_0003, and then try to kill a
> job passing id job_201208221603_003, it will kill job_201208221603_0003
> because the last part of the JobID is parsed as an integer. We should make
> JobID.forName() stricter to prevent this and similar situations as the
> current behavior isn't so obvious.
> More specifically, we shouldn't accept JobIDs if the last part of the JobID
> is:
> {{-}} less than 4 characters (e.g. _003, _123)
> {{-}} more than 4 characters and has a leading zero (e.g. _00003, _01234)
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
