[
https://issues.apache.org/jira/browse/MAPREDUCE-5797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935965#comment-13935965
]
Jonathan Eagles commented on MAPREDUCE-5797:
--------------------------------------------
[~shahrs87], in general I like it. Couple of minor nits.
*Hadoop uses the java oracle coding standards roughly, with the exceptions that
tabs are expanded and we use 2 spaces to indent. I highly recommend the
indentation and white space sections for gotchas. For example keywords followed
by a parenthesis should have a space in between.
http://wiki.apache.org/hadoop/HowToContribute
*Of course, all things have exceptions like maintaining the edited files
current formatting, however wrong.
*Separate out the test cases and name them appropriate to describe the feature
under test. Example, testNegativeStartTime, testNegativeEndTime. This way when
it fails, the feature that is broken is immediately evident.
Sorry for the overly long comment. Welcome to the Apache Hadoop community. We
are happy to have you onboard.
> Elapsed time for failed tasks that never started is wrong
> ------------------------------------------------------------
>
> Key: MAPREDUCE-5797
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5797
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobhistoryserver, webapps
> Affects Versions: 0.23.9
> Reporter: Rushabh S Shah
> Assignee: Rushabh S Shah
> Attachments: patch-MapReduce-5797-v2.patch, patch-MapReduce-5797.patch
>
>
> The elapsed time for tasks in a failed job that were never
> started can be way off. It looks like we're marking the start time as the
> beginning of the epoch (i.e.: start time = -1) but the finish time is when the
> task was marked as failed when the whole job failed. That causes the
> calculated elapsed time of the task to be a ridiculous number of hours.
> Tasks that fail without any attempts shouldn't have start/finish/elapsed
> times.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
