[
https://issues.apache.org/jira/browse/MAPREDUCE-5787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajesh Balamohan updated MAPREDUCE-5787:
----------------------------------------
Attachment: MAPREDUCE-5787-2.4.0-v5.patch
Incorporated review comments from Vinod
>> Can we also change the MapReduce fetcher to use keep-alive depending on
>> whether it is enabled or not?
- HttpURLConnection will automatically use persistent connection when
keep-alive and Content-Length headers are properly set. So, there is no need
to change the fetcher code.
>> Suggestion for Configuration renames
- Fixed
>>Add both to the mapred-default.xml
- Fixed
>>LOG KeepAliveParam along with other things like jobId, mapId etc.
-Fixed
>> populateHeaders. We are already parsing jobID, ApplicationId etc as part of
>> sendMapOutput. We should avoid doing the string parsing multiple times.
>> Is setting CONTENT_LENGTH important? Even so, for doing it, we are reading
>> the index-record two times
- Yes, content-length is very much needed for this. Fixed multiple parsing
issue.
>>Instead of re-defining new constants like CONNECTION_HEADER in
>>ShuffleHandler, can you use the standard constants in java (HttpHeaders)?
- Fixed
>> Finally, can you reuse code between the two tests?
- Fixed
> Modify ShuffleHandler to support Keep-Alive
> -------------------------------------------
>
> Key: MAPREDUCE-5787
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5787
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: nodemanager
> Affects Versions: 2.4.0
> Reporter: Rajesh Balamohan
> Assignee: Rajesh Balamohan
> Priority: Critical
> Labels: ShuffleKeepalive
> Attachments: MAPREDUCE-5787-2.4.0-v2.patch,
> MAPREDUCE-5787-2.4.0-v3.patch, MAPREDUCE-5787-2.4.0-v4.patch,
> MAPREDUCE-5787-2.4.0-v5.patch, MAPREDUCE-5787-2.4.0.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
