[
https://issues.apache.org/jira/browse/MAPREDUCE-5742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13957203#comment-13957203
]
Hiroshi Ikeda commented on MAPREDUCE-5742:
------------------------------------------
The added patch seems invalid at line 10, which should have a space for the
blank line.
I think it is better to use the default constructor if the
SecureRandom.getInstance throws NoSuchAlgorithmException.
I like chaining methods for a builder, but up to you :)
Indents are odd.
> pipes.Application should use SecureRandom for security purposes
> ---------------------------------------------------------------
>
> Key: MAPREDUCE-5742
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5742
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Hiroshi Ikeda
> Assignee: jhanver chand sharma
> Priority: Trivial
> Attachments: MapReduce-5742.patch, mapreduce-5742.patch
>
>
> org.apache.hadoop.mapred.pipes.Application calls its private method
> getSecurityChallenge(), which uses java.util.Random. It should use
> java.security.SecureRandom.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
