[
https://issues.apache.org/jira/browse/MAPREDUCE-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969904#comment-13969904
]
Chris Nauroth commented on MAPREDUCE-5827:
------------------------------------------
Hi, [~zjshen]. This looks mostly good to me. Similar to my comment earlier
today on a different issue, I recommend using {{GenericTestUtils#waitFor}} with
a max wait longer than the current 10 seconds. This is preferrable over
possibly leaving an infinite looping thread and relying on the JUnit timeout.
That could still leave a hung JVM running in the background after the whole
test suite finishes. This can disrupt subsequent test suites that try to
reformat a mini-cluster using the same test data directory.
> TestSpeculativeExecutionWithMRApp fails
> ---------------------------------------
>
> Key: MAPREDUCE-5827
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5827
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Zhijie Shen
> Assignee: Zhijie Shen
> Labels: test
> Attachments: MAPREDUCE-5827.1.patch
>
>
> {code}
> junit.framework.AssertionFailedError: Couldn't speculate successfully
> at junit.framework.Assert.fail(Assert.java:50)
> at junit.framework.Assert.assertTrue(Assert.java:20)
> at
> org.apache.hadoop.mapreduce.v2.TestSpeculativeExecutionWithMRApp.testSpeculateSuccessfulWithoutUpdateEvents(TestSpeculativeExecutionWithMRApp.java:122
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
