[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13990904#comment-13990904
 ] 

Jason Lowe commented on MAPREDUCE-5814:
---------------------------------------

The explicit listing of the various default.xml files seems like a reasonable 
approach.

Has there been any manual testing of the patch?  Since it reformats the system 
classes for readability it looks like it will not work for org.apache.hadoop. 
and mapred-default.xml.  Those will now have a newline character and multiple 
spaces prepended to their names and therefore won't ever match.  We either need 
to remove whitespace from the value or change MRApps#setJobClassLoader to use 
conf.getTrimmedStrings instead of conf.getStrings.

> fat jar with *-default.xml may fail when mapreduce.job.classloader=true.
> ------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5814
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5814
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 2.3.0
>            Reporter: Gera Shegalov
>            Assignee: Gera Shegalov
>         Attachments: MAPREDUCE-5814.v01.patch
>
>
> We faced a failure when a job.jar compiled against 0.20+ hadoop artifacts had 
> to run with {{mapreduce.job.classloader=true}} because it needed a more 
> recent guava as a dependency. The job failed because the cluster's 
> {{*-default.xml}} files were overshadowed by the ones in the fat jar. We 
> propose to treat these default config files like the system packages 
> {{org.apache.hadoop.}} to avoid a counterintuitivie behavior as if we had 
> {{mapreduce.job.user.classpath.first}} set.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to