[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14043972#comment-14043972
 ] 

Jason Lowe commented on MAPREDUCE-5939:
---------------------------------------

Thanks for posting a patch, Chen.  Patch approach looks good, and I just have 
some minor nits:

* We've already parsed, or at least tried to parse, the submit time earlier.  
Rather than re-parsing the submit time index again we can just do 
indexInfo.getSubmitTime()
* Formatting: a space should be before the brace for the {{if}}
* The test case name should be more specific to the nature of the test, e.g.: 
testJobStartTimeBackwardsCompatible or something similar.

> StartTime showing up as the epoch time in JHS UI after upgrade
> --------------------------------------------------------------
>
>                 Key: MAPREDUCE-5939
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5939
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 2.5.0
>            Reporter: Kihwal Lee
>            Assignee: Chen He
>         Attachments: MAPREDUCE-5939-v2.patch, MAPREDUCE-5939.patch
>
>
> After upgrading from 0.23.x to 2.5, the start time of old apps are showing up 
> as the epoch time.  It looks like 2.5 expects start time to be encoded at the 
> end of the jhist file name (....xxxx-[timestamp].jhist). It should have been 
> made backward compatible.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to