[ https://issues.apache.org/jira/browse/MAPREDUCE-5875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14057819#comment-14057819 ]
Hadoop QA commented on MAPREDUCE-5875: -------------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12655029/MAPREDUCE-5875.v08.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4725//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4725//console This message is automatically generated. > Make Counter limits consistent across JobClient, MRAppMaster, and YarnChild > --------------------------------------------------------------------------- > > Key: MAPREDUCE-5875 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5875 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: applicationmaster, client, task > Affects Versions: 2.4.0 > Reporter: Gera Shegalov > Assignee: Gera Shegalov > Attachments: MAPREDUCE-5875.v01.patch, MAPREDUCE-5875.v02.patch, > MAPREDUCE-5875.v03.patch, MAPREDUCE-5875.v04.patch, MAPREDUCE-5875.v05.patch, > MAPREDUCE-5875.v06.patch, MAPREDUCE-5875.v07.patch, MAPREDUCE-5875.v08.patch > > > Currently, counter limits "mapreduce.job.counters.*" handled by > {{org.apache.hadoop.mapreduce.counters.Limits}} are initialized > asymmetrically: on the client side, and on the AM, job.xml is ignored whereas > it's taken into account in YarnChild. > It would be good to make the Limits job-configurable, such that max > counters/groups is only increased when needed. With the current Limits > implementation relying on static constants, it's going to be challenging for > tools that submit jobs concurrently without resorting to class loading > isolation. > The patch that I am uploading is not perfect but demonstrates the issue. -- This message was sent by Atlassian JIRA (v6.2#6252)