[
https://issues.apache.org/jira/browse/MAPREDUCE-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068229#comment-14068229
]
Hadoop QA commented on MAPREDUCE-5981:
--------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12656504/MAPREDUCE-5981.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4756//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4756//console
This message is automatically generated.
> Log levels of certain MR logs can be changed to DEBUG
> -----------------------------------------------------
>
> Key: MAPREDUCE-5981
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5981
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Varun Saxena
> Assignee: Varun Saxena
> Attachments: MAPREDUCE-5981.patch
>
>
> Following map reduce logs can be changed to DEBUG log level.
> 1. In
> org.apache.hadoop.mapreduce.task.reduce.Fetcher#copyFromHost(Fetcher.java :
> 313), the second log is not required to be at info level. This can be moved
> to debug as a warn log is anyways printed if verifyReply fails.
> SecureShuffleUtils.verifyReply(replyHash, encHash, shuffleSecretKey);
> LOG.info("for url="+msgToEncode+" sent hash and received reply");
> 2. Thread related info need not be printed in logs at INFO level. Below 2
> logs can be moved to DEBUG
> a) In
> org.apache.hadoop.mapreduce.task.reduce.ShuffleSchedulerImpl#getHost(ShuffleSchedulerImpl.java
> : 381), below log can be changed to DEBUG
> LOG.info("Assigning " + host + " with " + host.getNumKnownMapOutputs() +
> " to " + Thread.currentThread().getName());
> b) In
> org.apache.hadoop.mapreduce.task.reduce.ShuffleScheduler.getMapsForHost(ShuffleSchedulerImpl.java
> : 411), below log can be changed to DEBUG
> LOG.info("assigned " + includedMaps + " of " + totalSize + " to " +
> host + " to " + Thread.currentThread().getName());
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
