[
https://issues.apache.org/jira/browse/MAPREDUCE-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087260#comment-14087260
]
Todd Lipcon commented on MAPREDUCE-5976:
----------------------------------------
Sorry for the delay here. The patch mostly looks good. Just a couple of nits:
{code}
+ if (job.getBoolean(MRJobConfig.MAP_OUTPUT_COMPRESS, false) == true) {
{code}
style: just use {{if (job.getBoolean(...))}} instead of comparing {{ == true }}.
{code}
+ String codec = job.get(MRJobConfig.MAP_OUTPUT_COMPRESS_CODEC);
+ if
(NativeRuntime.supportCompressionCodec(codec.getBytes(Charsets.UTF_8)) ==
false) {
{code}
Same -- just use {{!NativeRuntime.supportCompressionCodec(...)}} instead of
comparing {{ == false}}
Also, English nit: should be named {{supportsCompressionCodec}} (note the 's')
{code}
+ String message = "Native output collector don't support compression
codec " + codec;
{code}
Nit: should be "doesn't support" instead of "don't support"
{code}
+ *
+ * @param codecName
+ * @return
{code}
Remove these empty JavaDoc lines, since the main description of the function is
sufficient to understand it.
> native-task should not fail to build if snappy is missing
> ---------------------------------------------------------
>
> Key: MAPREDUCE-5976
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5976
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: task
> Reporter: Todd Lipcon
> Assignee: Sean Zhong
> Attachments: mapreduce-5976-v2.txt, mapreduce-5976.txt
>
>
> Other native parts of Hadoop will automatically disable snappy support if
> snappy is not present and -Drequire.snappy is not passed. native-task should
> do the same. (right now, it fails to build if snappy is missing)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
