[
https://issues.apache.org/jira/browse/MAPREDUCE-5885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Lowe updated MAPREDUCE-5885:
----------------------------------
Status: Open (was: Patch Available)
Thanks for the patch, Chen! Some comments:
We should covert these test cases to junit 4 while we're here.
Rather than wrap every test case with try...finally it would be cleaner to use
an After method to let junit do the cleanup call for us. This would result in
a much smaller patch as well.
Similarly the configure() method in TestComparators and TestMapOutputType
should be tagged with a Before junit decorator so it's automatically called
rather than having each test call it.
Nit: Is there a reason we're using simple class name with a "-mapred" suffix
for the directory rather than just .class.getName()? The latter is done by a
lot of other test cases, so wondering why we're deviating from that precedent.
> build/test/test.mapred.spill causes release audit warnings
> ----------------------------------------------------------
>
> Key: MAPREDUCE-5885
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5885
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: trunk
> Reporter: Jason Lowe
> Assignee: Chen He
> Attachments: MAPREDUCE-5885.patch, MAPREDUCE-5885.patch,
> MAPREDUCE-5885.patch
>
>
> Multiple unit tests are creating files under
> hadoop-mapreduce-client-jobclient/build/test/test.mapred.spill which are
> causing release audit warnings during Jenkins patch precommit builds. In
> addition to being in a poor location for test output and not cleaning up
> after the test, there are multiple tests using this location which will cause
> conflicts if tests are run in parallel.
--
This message was sent by Atlassian JIRA
(v6.2#6252)