[
https://issues.apache.org/jira/browse/MAPREDUCE-5885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112317#comment-14112317
]
Jason Lowe commented on MAPREDUCE-5885:
---------------------------------------
bq. I guess they think there will never be chance to run test in parallel?
That's exactly why it's kind of important to use something like .class.getName
for the test directory. It help makes the directory unique in light of
parallel tests and future code development. Two classes, like hypothetically
org.apache.hadoop.mapred.TestMapReduce and
org.apache.hadoop.mapreduce.TestMapReduce, will end up with separate test
directories if .class.getName is used. If they just use a hardcoded string
like "TestMapReduce" and one test copy-n-pasted from the other then they could
collide during parallel testing in a difficult to reproduce and diagnose
manner. I suspect the original tests used the same directory by pasting the
same code, and using .class.getName helps prevent that from causing problems.
But it's just a nit and the directories won't collide as-is, so we don't have
to fix that.
+1, committing this.
> build/test/test.mapred.spill causes release audit warnings
> ----------------------------------------------------------
>
> Key: MAPREDUCE-5885
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5885
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: trunk
> Reporter: Jason Lowe
> Assignee: Chen He
> Attachments: MAPREDUCE-5885-1.patch, MAPREDUCE-5885.patch,
> MAPREDUCE-5885.patch, MAPREDUCE-5885.patch
>
>
> Multiple unit tests are creating files under
> hadoop-mapreduce-client-jobclient/build/test/test.mapred.spill which are
> causing release audit warnings during Jenkins patch precommit builds. In
> addition to being in a poor location for test output and not cleaning up
> after the test, there are multiple tests using this location which will cause
> conflicts if tests are run in parallel.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
