[
https://issues.apache.org/jira/browse/MAPREDUCE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113292#comment-14113292
]
Manu Zhang commented on MAPREDUCE-6055:
---------------------------------------
Hi, Todd. The patch looks good generally, except for
1. The following change causes compilation error at my side (optimized away by
IDE ?)
{code}
public class DefaultSerializer implements INativeSerializer<Writable> {
static class ModifiedByteArrayOutputStream extends ByteArrayOutputStream {
@@ -37,7 +39,6 @@
private final ModifiedByteArrayOutputStream outBuffer = new
ModifiedByteArrayOutputStream();
private final DataOutputStream outData = new DataOutputStream(outBuffer);
- private Writable buffered = null;
private int bufferedLength = -1;
{code}
2. org.apache.hadoop.mapreduce.nativetask.Platform is intended to be extended
by external platforms. The public API for users are Platform, INativeComparable
and INativeSerializer<T>.
> native-task: findbugs, interface annotations, and other misc cleanup
> --------------------------------------------------------------------
>
> Key: MAPREDUCE-6055
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6055
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: task
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: mapreduce-6055.txt
>
>
> A few items which we need to address before merge:
> - fix findbugs errors
> - add interface and stability annotations to all public classes
> - fix eclipse warnings where possible
--
This message was sent by Atlassian JIRA
(v6.2#6252)
