[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114761#comment-14114761
 ] 

Xuan Gong commented on MAPREDUCE-6052:
--------------------------------------

Thanks for the patch, [~djp].
Overall looks good. But I still have one question:
Currently, we have the same container-log4j.properties for all NMs. No matter 
which NM the containers will be launched, they will always get the same 
container-log4j.properties. So, if we use customized log4j properties, do we 
need to distribute this file to all the NMs (just like the default 
container-log4j.properties) ? Otherwise, If we use the customized log4j 
properties which exist in local file system, I am afraid that for other 
containers which are launched in other NMs can not get this customized log4j 
properties.
Maybe you could test the patch in multi-node cluster to verify it.

> Support overriding log4j.properties per job
> -------------------------------------------
>
>                 Key: MAPREDUCE-6052
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6052
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 2.5.0
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: MAPREDUCE-6052.patch
>
>
> For current MR application, the "log4j.configuration" is hard coded to 
> container-log4j.properties within each node. We still need flexibility to 
> override it per job like what we do in MRV1.
> {code}
>   public static void addLog4jSystemProperties(
>       String logLevel, long logSize, int numBackups, List<String> vargs) {
>     vargs.add("-Dlog4j.configuration=container-log4j.properties");
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to