[
https://issues.apache.org/jira/browse/MAPREDUCE-6063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118619#comment-14118619
]
Hadoop QA commented on MAPREDUCE-6063:
--------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12665960/MAPREDUCE-6063.000.patch
against trunk revision 6595e92.
{color:red}-1 patch{color}. Trunk compilation may be broken.
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4840//console
This message is automatically generated.
> In sortAndSpill of MapTask.java, size is calculated wrongly when bufend <
> bufstart.
> -----------------------------------------------------------------------------------
>
> Key: MAPREDUCE-6063
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6063
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv1, mrv2
> Reporter: zhihai xu
> Assignee: zhihai xu
> Attachments: MAPREDUCE-6063.000.patch
>
>
> In sortAndSpill of MapTask.java, size is calculated wrongly when bufend <
> bufstart. we should change (bufvoid - bufend) + bufstart to (bufvoid -
> bufstart) + bufend.
> Should change
> {code}
> long size = (bufend >= bufstart
> ? bufend - bufstart
> : (bufvoid - bufend) + bufstart) +
> partitions * APPROX_HEADER_LENGTH;
> {code}
> to:
> {code}
> long size = (bufend >= bufstart
> ? bufend - bufstart
> : (bufvoid - bufstart) + bufend) +
> partitions * APPROX_HEADER_LENGTH;
> {code}
> It is because when wraparound happen (bufend < bufstart) , the size should
> bufvoid - bufstart (bigger one) + bufend(small one).
> You can find similar code implementation in MapTask.java:
> {code}
> mapOutputByteCounter.increment(valend >= keystart
> ? valend - keystart
> : (bufvoid - keystart) + valend);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
