[
https://issues.apache.org/jira/browse/MAPREDUCE-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Todd Lipcon updated MAPREDUCE-6069:
-----------------------------------
Attachment: mr-6069.txt
Oops, I'd uploaded the wrong path file previously. This one should compile.
Regarding splitting it up - I originally had this as several patches, but in
many cases removing just one piece of code doens't work since other call sites
are left. So, it's hard to really split it up into a lot of small pieces. Doing
the style fixes separately seemed difficult because I didn't want to bother
fixing the style in the code that I was about to delete. So, in the end I
combined all the patches. To try to make it easier to review, I kept a list of
the changes made, which I pasted above.
Are there any specific concerns about the review? None of the system-level
tests have been modified in the patch, so I feel pretty confident that it won't
affect current use cases. The changes that aren't straight deletion of code
should be whitespace-only.
> native-task: Style fixups and dead code removal
> -----------------------------------------------
>
> Key: MAPREDUCE-6069
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6069
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: task
> Reporter: Todd Lipcon
> Attachments: mr-6069.txt, mr-6069.txt
>
>
> A few more cleanup things we should address:
> - fix style issues (eg lines too long, bad indentation, commented-out code
> blocks, etc) both in Java and C++
> - Found a few pieces of unused code by running a coverage tool. We should
> remove them
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
