[ https://issues.apache.org/jira/browse/MAPREDUCE-6103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147195#comment-14147195 ]
Chris Douglas commented on MAPREDUCE-6103: ------------------------------------------ The {{YARNRunner}} changes look good, though discussing with [~subru] there are a few conditions where {{ReservationId::parseReservationId()}} can be malformed, but return {{null}}. It might be clearer if this method were to throw an exception on all input that can't be parsed into a {{ReservationId}}, including null. +1 overall, though > Adding reservation APIs to resource manager delegate > ---------------------------------------------------- > > Key: MAPREDUCE-6103 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6103 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Reporter: Subru Krishnan > Assignee: Subru Krishnan > Attachments: MR-6103.patch, MR-6103.patch > > > YARN-1051 introduces the ReservationSystem and the corresponding APIs for > create/update/delete ops. The MR resource manager delegate needs to to be > updated with the APIs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)