[
https://issues.apache.org/jira/browse/MAPREDUCE-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170530#comment-14170530
]
Rohith commented on MAPREDUCE-5542:
-----------------------------------
Thanks Jasown Lowe for your review and comments..
bq. Is there a scenario where we can still get an NPE? I don't think it's
supposed to happen
I had doubt only on this case "for some reason it can't lookup the job ID then
YARN will think it's running and we still will NPE on the null status". This I
will update in patch.
bq. but I'm wondering if the app is still running and we send it a bad jobID.
IIUC, here JobStatus wont be null because before sending killJob, Job State
should be running.
bq. The isApplicationFinished method name is confusing since it can return true
for applications that are finished and happen to have a non-null job status
Agree
bq. The applicationStatus local in isApplicationFinished makes the code harder
to read
Agree
I will update patch soon.
> Killing a job just as it finishes can generate an NPE in client
> ---------------------------------------------------------------
>
> Key: MAPREDUCE-5542
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5542
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client, mrv2
> Affects Versions: 2.1.0-beta, 0.23.9
> Reporter: Jason Lowe
> Assignee: Rohith
> Attachments: MAPREDUCE-5542.1.patch, MAPREDUCE-5542.2.patch,
> MAPREDUCE-5542.3.patch
>
>
> If a client tries to kill a job just as the job is finishing then the client
> can crash with an NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
