[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216518#comment-14216518
 ] 

Hadoop QA commented on MAPREDUCE-6164:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12681914/MAPREDUCE-6164.patch
  against trunk revision b4ca727.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5029//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5029//console

This message is automatically generated.

> "mapreduce.reduce.shuffle.fetch.retry.timeout-ms" should be set to 3 minutes 
> instead of 30 seconds by default to be consistent with other retry timeout 
> --------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6164
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6164
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: MAPREDUCE-6164.patch
>
>
> In MAPREDUCE-5891, we are adding retry logic to MAPREDUCE shuffle stage for 
> fetcher can be survival during NM downtime (with shuffle service down as 
> well). In many places, we are setting the default timeout to be 3 minutes 
> (connection timeout, etc.) to tolerant possible more time for NM down, but we 
> are making "mapreduce.reduce.shuffle.fetch.retry.timeout-ms" to be 30 seconds 
> which is not consistent here. We should change this to 180 seconds. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to