[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14221569#comment-14221569
 ] 

Jian He commented on MAPREDUCE-5568:
------------------------------------

[~minjikim], thanks for your contribution. patch looks good, just some format 
issues:
- the convention is to use two spaces for indentation.
{code}
    if ( getTotalMaps() == 0 ) {
        report.setMapProgress(1.0f);
    } else {
    report.setMapProgress((float) getCompletedMaps() / getTotalMaps());
    }
    if ( getTotalReduces() == 0 ) {
        report.setReduceProgress(1.0f);
    } else {
    report.setReduceProgress((float) getCompletedReduces() / getTotalReduces());
    }
{code}

> JHS returns invalid string for reducer completion percentage if AM restarts 
> with 0 reducer.
> -------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5568
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5568
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 2.4.1, 2.5.1
>            Reporter: Jian He
>            Assignee: MinJi Kim
>         Attachments: 5568.patch01, 5568.patch02, 5568.patch03
>
>
> JobCLient shows like:
> {code}
> 13/10/05 16:26:09 INFO mapreduce.Job:  map 100% reduce NaN%
> 13/10/05 16:26:09 INFO mapreduce.Job: Job job_1381015536254_0001 completed 
> successfully
> 13/10/05 16:26:09 INFO mapreduce.Job: Counters: 26
>       File System Counters
>               FILE: Number of bytes read=0
>               FILE: Number of bytes written=76741
>               FILE: Number of read operations=0
>               FILE: Number of large read operations=0
>               FILE: Number of write operations=0
>               HDFS: Number of bytes read=48
>               HDFS: Number of bytes written=0
>               HDFS: Number of read operations=1
>               HDFS: Number of large read operations=0
>               HDFS: Number of write operations=0
> {code}
> With mapped job -status command, it shows:
> {code}
> Uber job : false
> Number of maps: 1
> Number of reduces: 0
> map() completion: 1.0
> reduce() completion: NaN
> Job state: SUCCEEDED
> retired: false
> reason for failure:
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to