[jira] [Commented] (MAPREDUCE-5014) Extending DistCp through a custom CopyListing is not possible

[Mathieu Chataigner (JIRA)]

    [ 
https://issues.apache.org/jira/browse/MAPREDUCE-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276876#comment-14276876
 ] 

Mathieu Chataigner commented on MAPREDUCE-5014:
-----------------------------------------------

the patch is simple:

diff --git 
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/CopyListing.java
 
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/CopyListing.java
index ab5b802..f7b4c1a 100644
--- 
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/CopyListing.java
+++ 
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/CopyListing.java
@@ -249,13 +249,13 @@ public static CopyListing getCopyListing(Configuration 
configuration,
     }
   }
 
-  static class DuplicateFileException extends RuntimeException {
+  public static class DuplicateFileException extends RuntimeException {
     public DuplicateFileException(String message) {
       super(message);
     }
   }
 
-  static class InvalidInputException extends RuntimeException {
+  public static class InvalidInputException extends RuntimeException {
     public InvalidInputException(String message) {
       super(message);
     }


> Extending DistCp through a custom CopyListing is not possible
> -------------------------------------------------------------
>
>                 Key: MAPREDUCE-5014
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5014
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: distcp
>    Affects Versions: 0.23.0, 0.23.1, 0.23.3, trunk, 0.23.4, 0.23.5
>            Reporter: Srikanth Sundarrajan
>            Assignee: Srikanth Sundarrajan
>             Fix For: 2.5.0
>
>         Attachments: MAPREDUCE-5014.patch, MAPREDUCE-5014.patch, 
> m5014_20130322.patch, m5014_20130322_b-1.patch, m5014_20130322b.patch, 
> m5014_20130322b_b-1.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> * While it is possible to implement a custom CopyListing in DistCp, DistCp 
> driver class doesn't allow for using this custom CopyListing.
> * Allow SimpleCopyListing to provide an option to exclude files (For instance 
> it is useful to exclude FileOutputCommiter.SUCCEEDED_FILE_NAME during copy as 
> premature copy can indicate that the entire data is available at the 
> destination)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)